lp:lttng-tools

Author: =?utf-8?q?J=C3=A9r=C3=A9mie_Galarneau?=
Author Date: 2023-10-06 19:17:41 UTC

Fix: sessiond: cmd potentially used uninitialized

GCC reports the following warning:

  libtool: compile: g++ -std=gnu++11 -DHAVE_CONFIG_H -I../../../include -I../../../include -I../../../src -I../../../src -include config.h -I/home/mjeanson/opt/include -I/home/mjeanson/opt/include -DINSTALL_BIN_PATH=\"/home/mjeanson/opt/lib/lttng/libexec\" -DINSTALL_LIB_PATH=\"/home/mjeanson/opt/lib\" -fvisibility=hidden -fvisibility-inlines-hidden -fno-strict-aliasing -Wall -Wextra -Wmissing-declarations -Wnull-dereference -Wundef -Wredundant-decls -Wshadow -Wsuggest-attribute=format -Wwrite-strings -Wformat=2 -Wstrict-aliasing -Wmissing-noreturn -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Winit-self -Wno-incomplete-setjmp-declaration -Wno-gnu-folding-constant -Wno-sign-compare -Werror -pthread -g -O2 -MT notification-thread-events.lo -MD -MP -MF .deps/notification-thread-events.Tpo -c notification-thread-events.cpp -fPIC -DPIC -o .libs/notification-thread-events.o
  In file included from field.hpp:14,
                   from ust-field-convert.hpp:11,
                   from ust-app.hpp:14,
                   from event-notifier-error-accounting.hpp:11,
                   from notification-thread-events.cpp:12:
  ../../../src/vendor/optional.hpp: In function ‘int handle_notification_thread_command(notification_thread_handle*, notification_thread_state*)’:
  ../../../src/vendor/optional.hpp:877:17: error: ‘cmd’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    877 | return &data;
        | ^~~~
  notification-thread-events.cpp:3181:45: note: ‘cmd’ was declared here
   3181 | struct notification_thread_command *cmd;
        |

When failing to pop a command, cmd can indeed be used uninitialized when
jumping to the error label.

Reported-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I5e63451ed4936638e9fbe05146f16c86ea2e42e2

Author: =?utf-8?q?J=C3=A9r=C3=A9mie_Galarneau?=
Author Date: 2023-04-13 19:50:57 UTC

Tests: fix: list_triggers_cli: kallsyms contains prefixed symbols

The test_list_triggers_cli test fails with:

  # Listing event-rule-matches kernel probe
  ./tests/regression/tools/trigger/test_list_triggers_cli: line 808: [[: 0xffffffffc1fca020
  ffffffffc1fca030: syntax error in expression (error token is "ffffffffc1fca030")
  ./tests/regression/tools/trigger/test_list_triggers_cli: line 813: 0xffffffffc1fca020
  ffffffffc1fca030 - 0xffffffffc1fca0c0
  ffffffffc1fca0b0 : syntax error in expression (error token is "ffffffffc1fca030 - 0xffffffffc1fca0c0
  ffffffffc1fca0b0 ")

This is due to the fact that /proc/kallsyms now contains prefixed
symbols (e.g. `__pfx_lttng_channel_enable`) which cause the test to fail
since the grep invocation doesn't expect more than one match.

Matching the begin/end of the "word" (or rather, function name) allows
us to check for exact matches only.

https://github.com/torvalds/linux/commit/9f2899fe36a623885d8576604cb582328ad32b3c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ifc04757719c733caf55c8eea447e18a2246a9f49

Author: Kienan Stewart
Author Date: 2023-06-21 13:39:06 UTC

Tests: Preemptively fail infinite blocking tests when low on disk space

In the system tests run by LAVA, the infinite blocking tests were
hanging when the system under test ran out of disk space. This is the
expected behaviour of the failing test, but the condition can be
detected and the tests preemptively failed with a clear error of what
needs to be addressed in the system being tested.

Change-Id: I9e6126408b57c2cd5aa64c2e360e0672f9eb2314
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: =?utf-8?q?J=C3=A9r=C3=A9mie_Galarneau?=
Author Date: 2021-10-18 21:10:34 UTC

Update version to v2.11.8

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2020-04-16 20:41:02 UTC

Update version to v2.9.15

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2020-04-16 20:40:13 UTC

Update version to v2.10.11

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2017-08-03 19:17:00 UTC

Update version to v2.8.8

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2016-12-01 23:07:42 UTC

Update version to v2.7.6

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2016-05-20 21:46:14 UTC

Update version to v2.6.3

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2015-09-25 04:22:48 UTC

Update version to v2.5.5

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: Jérémie Galarneau
Author Date: 2015-02-06 20:23:19 UTC

Test: java-jul:missing static test files for dist and out of tree build

Reported-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Author: David Goulet
Author Date: 2014-07-10 20:02:02 UTC

Fix: add a get HOME dir fallback to getpwuid

If the $HOME or $LTTNG_HOME is not defined, fallback on getpwuid(3) of
the process uid.

Fixes #815

Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: David Goulet
Author Date: 2014-02-28 17:55:41 UTC

Update version to v2.2.6

Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: David Goulet
Author Date: 2013-10-24 14:23:34 UTC

Merge branch 'master' into memleak-finder

Author: David Goulet
Author Date: 2013-07-11 21:27:44 UTC

Update version to v2.1.2

Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: David Goulet
Author Date: 2013-07-11 21:21:09 UTC

Update version to v2.0.6

Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: David Goulet
Author Date: 2012-12-10 19:35:23 UTC

Add valgrind support for consumer

The tests/consumer-valgrind is a script that starts the session daemon
with valgrind support for the consumer. Output files are:

/tmp/valgrind.ust32consumer.log
/tmp/valgrind.ust64consumer.log
/tmp/valgrind.kconsumer.log

Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: Christian Babeux
Author Date: 2012-12-21 18:47:16 UTC

Add a README.cygwin for Cygwin specific build/install instructions

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

Author: David Goulet
Author Date: 2012-04-25 15:41:28 UTC

Update hello for benchmarks

Signed-off-by: David Goulet <dgoulet@efficios.com>