MAAS

Merge lp://staging/~ltrager/maas/rootfs_over_http into lp://staging/~maas-committers/maas/trunk

rootfs_over_http
Merge into trunk

Proposed by Lee Trager on 2017-06-14

Status:

Merged

Approved by:

Blake Rouse on 2017-06-22

Approved revision:

no longer in the source branch.

Merged at revision:

6106

Proposed branch:

lp://staging/~ltrager/maas/rootfs_over_http

Merge into:

lp://staging/~maas-committers/maas/trunk

Diff against target:

479 lines (+98/-180)

6 files modified

src/maasserver/forms/settings.py (+9/-1)
src/maasserver/models/config.py (+3/-2)
src/maasserver/rpc/boot.py (+1/-0)
src/provisioningserver/kernel_opts.py (+44/-67)
src/provisioningserver/rpc/region.py (+1/-0)
src/provisioningserver/tests/test_kernel_opts.py (+40/-110)

To merge this branch:

bzr merge lp://staging/~ltrager/maas/rootfs_over_http

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Blake Rouse (community)		Approve on 2017-06-22
Andres Rodriguez (community)		Needs Fixing on 2017-06-21
Mike Pontillo (community)	2017-06-14	Approve on 2017-06-21
Review via email: mp+325655@code.staging.launchpad.net

Commit message

When booting the ephemeral environment, fetch the rootfs over HTTP instead of using iSCSI.

Revision history for this message

Mike Pontillo (mpontillo) wrote on 2017-06-14:

This looks like a nice improvement! A few questions below (mainly around IPv6 support; please add specific tests for that, too).

Somewhat related question: do we ever present a hostname in the fs_host, or is it always an IP address? (I assume it's just an IP address, and I think that's okay.)

We should also make sure we don't present an IPv6 link-local address as the fs_host (if we aren't doing that already).

review: Needs Information

Revision history for this message

Lee Trager (ltrager) wrote on 2017-06-16:

Thanks for the review. fs_host was being used by the ISCSI code so I assume it properly works with IPv6. I agree we need to do some IPv6 testing with this but I don't have access to an IPv6 enabled environment right now.

Revision history for this message

Mike Pontillo (mpontillo) wrote on 2017-06-16:

Thanks for the replies. In my view, only one thing needs to be done for this to land: add a separate IPv6 test case and ensure that IPv6 addresses have brackets surrounding them, while IPv4 addresses do not.

review: Needs Fixing

Revision history for this message

Lee Trager (ltrager) wrote on 2017-06-21:

Thanks for the review. I've updated the branch to ensure that [] are wrapped around IPv6 addresses.

Revision history for this message

Mike Pontillo (mpontillo) wrote on 2017-06-21:

Thanks for the fixes. Ship it!

review: Approve

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2017-06-21:

To follow on the discussion:

This needs to have a feature flag.

review: Needs Fixing

Revision history for this message

Lee Trager (ltrager) wrote on 2017-06-21:

Booting over iSCSI is now the default. To enable booting over HTTP use the MAAS configuration option http_boot.

Revision history for this message

Blake Rouse (blake-rouse) wrote on 2017-06-22:

This is okay as a global setting allow it to be changed over the API, which is nice. But this needs to be undocumented and removed before release. So this option should really be short lived.

review: Approve