Merge ~ltrager/maas:lp1722607_js into maas:master

Proposed by Lee Trager
Status: Merged
Approved by: Lee Trager
Approved revision: bf1ab2708d68af14e5cdd77f88f5732351c41df3
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ltrager/maas:lp1722607_js
Merge into: maas:master
Prerequisite: ~ltrager/maas:lp1722607_ws
Diff against target: 949 lines (+436/-308)
7 files modified
src/maasserver/static/js/angular/controllers/node_details.js (+0/-125)
src/maasserver/static/js/angular/controllers/node_results.js (+141/-11)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+1/-145)
src/maasserver/static/js/angular/controllers/tests/test_node_results.js (+230/-0)
src/maasserver/static/js/angular/factories/nodes.js (+13/-1)
src/maasserver/static/js/angular/factories/tests/test_nodes.js (+32/-0)
src/maasserver/static/partials/node-details.html (+19/-26)
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
MAAS Lander Approve
Review via email: mp+334624@code.staging.launchpad.net

Commit message

LP: #1722607 - 2/2 Stop sending logs with node object over the websocket.

Update the UI to pull summary data from NodesHandler and installation
data from the NodeResultsHandler. There are no UI changes with this
branch.

Description of the change

Using a virsh machine with no LLDP data with a deployed OS
Node object size master: 97973B
Node object size with branch: 13884B

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1722607_js lp:~ltrager/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/880/console
COMMIT: 51f86f795d0ac4ed686b6fd841663eb37692438c

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1722607_js lp:~ltrager/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 6771a26ea02a8321d9c33cafe7021aa796e84c64

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1722607_js lp:~ltrager/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 95350a37792ac4e7d718f2fb507e75558f3bcb9b

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good, minus the "}else" all over the place. Why the missing space? "} else" reads much better! ;-)

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches