Merge ~ltrager/maas:lp1705508 into maas:master

Proposed by Lee Trager
Status: Merged
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ltrager/maas:lp1705508
Merge into: maas:master
Diff against target: 33 lines (+9/-2)
2 files modified
src/maasserver/bootsources.py (+5/-0)
src/maasserver/tests/test_bootsources.py (+4/-2)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+328054@code.staging.launchpad.net

Commit message

Set the no_proxy environment variable to 127.0.0.1,localhost.

When MAAS starts importing boot resources it sets the proxy environment
variables for the whole process, if an external proxy is set. No exceptions were made for 127.0.0.1 or localhost. Region refresh sends results to itself over HTTP. Because no exceptions were allowed region refresh failed.

Fixes: LP: #1705508

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Please backport this to 2.2.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches