maas-images

Merge lp://staging/~ltrager/maas-images/lpxelinux into lp://staging/maas-images

lpxelinux
Merge into maas-ephemerals

Proposed by Lee Trager on 2018-07-17

Status:	Merged
Merged at revision:	403
Proposed branch:	lp://staging/~ltrager/maas-images/lpxelinux
Merge into:	lp://staging/maas-images
Diff against target:	11 lines (+1/-0) 1 file modified conf/bootloaders.yaml (+1/-0)
To merge this branch:	bzr merge lp://staging/~ltrager/maas-images/lpxelinux
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Scott Moser (community)		Abstain on 2018-07-18
Blake Rouse (community)		Approve on 2018-07-17
Newell Jensen (community)	2018-07-17	Approve on 2018-07-17
Review via email: mp+349781@code.staging.launchpad.net

Commit message

Ship lpxelinux.0 with the PXE bootloader

Revision history for this message

Newell Jensen (newell-jensen) wrote on 2018-07-17:

review: Approve

Revision history for this message

Blake Rouse (blake-rouse) wrote on 2018-07-17:

Looks good.

review: Approve

Revision history for this message

Scott Moser (smoser) wrote on 2018-07-18:

Its good to say *why* you are doing something in commit messages.

it seems like some more context would probably have been available.
Why did we decided to ship the 'lpxelinux.0' ? was there a bug ? does this enable something?

:-(

review: Abstain

Revision history for this message

Lee Trager (ltrager) wrote on 2018-07-18:

@smoser - lpxelinux.0 is pxelinux.0 with HTTP support. As of MAAS 2.5 the rack controller serves HTTP files using nginx which is much faster then any TFTP server, including the one built into MAAS. Blake has modified MAAS [1] to use lpxelinux.0 so the kernel and initrd are retrieved over HTTP instead of TFTP which allows MAAS to serve many more clients.

Sorry for the light commit message.

[1] https://code.launchpad.net/~blake-rouse/maas/+git/maas/+merge/349820