Merge lp://staging/~ltrager/maas-images/centos_storage_curthooks into lp://staging/maas-images

Proposed by Lee Trager
Status: Merged
Merged at revision: 408
Proposed branch: lp://staging/~ltrager/maas-images/centos_storage_curthooks
Merge into: lp://staging/maas-images
Diff against target: 164 lines (+56/-40)
2 files modified
conf/centos.yaml (+10/-3)
curtin/centos7/curtin-hooks.py (+46/-37)
To merge this branch: bzr merge lp://staging/~ltrager/maas-images/centos_storage_curthooks
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+353351@code.staging.launchpad.net

Commit message

Update CentOS 7 curthooks to use internal Curtin storage support.

Curtin now supports deploying custom storage on CentOS 7+. Hooks are no
longer required for CentOS but they are still included for backwards
compatibility. If CentOS is deployed with MAAS 2.5+ and a supported version of Curtin the hooks will simply call back into Curtin to configure storage.
If an older version of MAAS or Curtin is used the old hooks will still run.

Description of the change

Stream with updated CentOS 7 image: http://162.213.35.187/centos-storage/

Testing:
I tested in the CI and configured a BIOS and UEFI machine with 2 disk to have a btrfs filesystem for / on LVM on top of a RAID 1 over 2 disks

MAAS-2.4.1 + curtin-18.1-17-gae48e86f-0ubuntu1~18.04.1(stable) - Flat layout
MAAS-2.4.1 + curtin+centos-storage - Flat layout
MAAS-master + curtin-18.1-17-gae48e86f-0ubuntu1~18.04.1 - Flat layout
MAAS-master + curtin+centos-storage - Custom storage layout deployed!

* curtin+centos-storage - https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/349075

To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) :
Revision history for this message
Lee Trager (ltrager) wrote :

Thanks for the review. I've updated to use the real package name as discussed on IRC. I was also able to confirm custom storage deployment works :)

414. By Lee Trager

Cleanup package order

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Question inline.

review: Needs Information
Revision history for this message
Lee Trager (ltrager) wrote :

We're not supporting custom storage on CentOS 6 so its Curtin hooks remain the same. grub2-efi-x64 is only added to the list of packages added to the CentOS 7 image.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! But this should land if and only if the hooks are exactly like those in maas-image-builder

review: Approve
Revision history for this message
Lee Trager (ltrager) wrote :

Yes they are exactly the same

$ diff -u maas-images/centos_storage_curthooks/curtin/centos7/ maas-image-builder/contrib/centos/centos7/curtin/
$

415. By Lee Trager

Don't include grub2-efi-x64

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches