maas-images

Merge lp://staging/~ltrager/maas-images/bootloaders_part2 into lp://staging/maas-images

bootloaders_part2
Merge into maas-ephemerals

Proposed by Lee Trager on 2016-08-18

Status:	Merged
Merged at revision:	325
Proposed branch:	lp://staging/~ltrager/maas-images/bootloaders_part2
Merge into:	lp://staging/maas-images
Diff against target:	485 lines (+231/-104) 3 files modified conf/bootloaders.yaml (+21/-13) meph2/commands/dpkg.py (+133/-8) meph2/commands/meph2_util.py (+77/-83)
To merge this branch:	bzr merge lp://staging/~ltrager/maas-images/bootloaders_part2
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Scott Moser (community)		2016-08-18	Approve on 2016-08-24
Review via email: mp+303241@code.staging.launchpad.net

Description of the change

Update bootloader format as per discussion in https://code.launchpad.net/~ltrager/maas-images/rename_squashfs/+merge/302353

Sample output:
http://paste.ubuntu.com/23083035/

lp://staging/~ltrager/maas-images/bootloaders_part2 updated on 2016-08-23

324. By Lee Trager on 2016-08-23: Put os in bootloader product name
325. By Lee Trager on 2016-08-23: Use bootloaders from Xenial

Revision history for this message

Lee Trager (ltrager) wrote on 2016-08-23:

As discussed on IRC pull the bootloaders from Xenial. The sample output has been updated.

Revision history for this message

Scott Moser (smoser) wrote on 2016-08-24:

the data looks good.

i have one nit pick in the conf/bootloaders.yaml
I think better to have:

files:
- usr/lib/grub/arm64-efi

than

files:
- /usr/lib/grub/arm64-efi

just to make it clear that the files are coming from the package itself and not the isntalled system, and also to avoid the pitfall of:
os.path.join("/home/smoser", "/etc/passwd") == "/etc/passwd"

review: Approve

lp://staging/~ltrager/maas-images/bootloaders_part2 updated on 2016-08-24