Merge lp://staging/~lorn-potter/qtubuntu-media/add-buffering_changed into lp://staging/qtubuntu-media

Proposed by Lorn Potter
Status: Merged
Approved by: Jim Hodapp
Approved revision: 113
Merged at revision: 109
Proposed branch: lp://staging/~lorn-potter/qtubuntu-media/add-buffering_changed
Merge into: lp://staging/qtubuntu-media
Diff against target: 182 lines (+36/-3)
8 files modified
debian/control (+1/-1)
src/aal/aalmediaplayercontrol.cpp (+1/-2)
src/aal/aalmediaplayerservice.cpp (+15/-0)
src/aal/aalmediaplayerservice.h (+5/-0)
tests/unit/player.cpp (+6/-0)
tests/unit/player.h (+1/-0)
tests/unit/player_mock.cpp (+6/-0)
tests/unit/player_mock.h (+1/-0)
To merge this branch: bzr merge lp://staging/~lorn-potter/qtubuntu-media/add-buffering_changed
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+296731@code.staging.launchpad.net

Commit message

Add media buffering signal handling

Description of the change

Add media buffering signal handling

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Several comments inline below.

review: Needs Fixing (code)
110. By Lorn Potter

code review fixups

111. By Lorn Potter

fix unit test for buffering change

112. By Lorn Potter

Use DirectConnection for buffering signal

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Just a couple of fixes left.

review: Needs Fixing
113. By Lorn Potter

change buffering test player to static const review

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM!

review: Approve (code)
114. By Lorn Potter

bump media-hub version requirements

115. By Lorn Potter

bump version requirements for media-hub

116. By Lorn Potter

media-hub requirements for 4.3.0

117. By Lorn Potter

bump media-hub required version

118. By Lorn Potter

drop specific build version from media-hub dependency

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches