unity-lens-files

Merge lp://staging/~lore-mattei/unity-lens-files/unity-lens-files-lp878052 into lp://staging/unity-lens-files

  1. unity-lens-files-lp878052
  2. Merge into trunk
Proposed by Lorenzo Mattei
Status: Rejected
Rejected by: Łukasz Zemczak
Proposed branch: lp://staging/~lore-mattei/unity-lens-files/unity-lens-files-lp878052
Merge into: lp://staging/unity-lens-files
Diff against target: 21 lines (+5/-2)
1 file modified
src/daemon.vala (+5/-2)
To merge this branch: bzr merge lp://staging/~lore-mattei/unity-lens-files/unity-lens-files-lp878052
Reviewer Review Type Date Requested Status
Bernhard Kaindl (community) Approve
Michal Hruby Pending
Mikkel Kamstrup Erlandsen Pending
Unity Team Pending
Review via email: mp+104008@code.staging.launchpad.net

Description of the change

For local files only, gets the folder name from uri and checks if it is hidden. If so, skips the file.

To post a comment you must log in.
Revision history for this message
Bernhard Kaindl (benkai) wrote :

I think merging this should be a clear cut, I wonder why it takes so long.

review: Approve
Revision history for this message
Omer Akram (om26er) wrote :

I will try to ping someone on Monday.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Technically it only solves this partially, since it only checks the
state of the immediate parent dir. ~/.foo/bar/secret.txt would still
show up. Recursively stat()ing the parent dirs is not very fun either.

I suggested some point in the past that we do a simple heuristic that
I think is "good enough" - simply checking if the path string contains
a "/." pattern.

Unmerged revisions

229. By Lorenzo Mattei

Skip files in hidden folders.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches