Merge lp://staging/~lool/ubuntu-system-image/downloader-packaging-updates into lp://staging/~registry/ubuntu-system-image/downloader-dailies

Proposed by Loïc Minier
Status: Merged
Merged at revision: 7
Proposed branch: lp://staging/~lool/ubuntu-system-image/downloader-packaging-updates
Merge into: lp://staging/~registry/ubuntu-system-image/downloader-dailies
Diff against target: 67 lines (+21/-12)
2 files modified
control (+19/-12)
libubuntudownloadmanager-dev.install (+2/-0)
To merge this branch: bzr merge lp://staging/~lool/ubuntu-system-image/downloader-packaging-updates
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Review via email: mp+175296@code.staging.launchpad.net

Description of the change

Misc updates; unfortunately the -dev package (last commit) doesn't build and I couldn't easily get qmake to install the right headers, it seems painful to do this correctly with qmake. It seems other packages use cmake though (like libubuntu-location-service), so that might be a quicker path to addressing this?

Cheers,

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

Great, I'll merge the branch and will take a look on how to tell qmake to install headers for the dev package. Nevertheless it is not a huge bug since currently the daemon is the only one using the library.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches