libubuntuone

Merge lp://staging/~lool/libubuntuone/out-of-tree-keyfile-lp-688538 into lp://staging/libubuntuone

  1. out-of-tree-keyfile-lp-688538
  2. Merge into trunk
Proposed by Loïc Minier
Status: Rejected
Rejected by: dobey
Proposed branch: lp://staging/~lool/libubuntuone/out-of-tree-keyfile-lp-688538
Merge into: lp://staging/libubuntuone
Diff against target: 17 lines (+6/-1)
1 file modified
bindings/mono/Makefile.am (+6/-1)
To merge this branch: bzr merge lp://staging/~lool/libubuntuone/out-of-tree-keyfile-lp-688538
Reviewer Review Type Date Requested Status
dobey (community) Disapprove
Review via email: mp+43645@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

This seems like the wrong way to solve the problem. I'm sure it works as a quick fix to the package itself, but we should make this more robust in the upstream source, and add a test to ensure the signing actually works during distcheck.

review: Disapprove
Revision history for this message
dobey (dobey) wrote :

I've filed a separate bug against libubuntuone for the more specific srcdir != builddir issue. I've also made a more robust fix and proposed it in https://code.edge.launchpad.net/~dobey/libubuntuone/srcdir-signing/+merge/43668 so I'm going to mark this as rejected in favor of that implementation instead. Thanks.

Unmerged revisions

111. By Loïc Minier

bindings/mono/Makefile.am: if srcdir != builddir, copy mono.snk keyfile
into builddir and pass $(srcdir)/*.cs to gmcs as to include
AssemblyInfo.cs and hence properly sign the DLL; LP: #688538.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches