Merge lp://staging/~loneowais/ubuntu/precise/rhythmbox/remember-the-rhythm into lp://staging/ubuntu/precise/rhythmbox

Proposed by Owais Lone
Status: Work in progress
Proposed branch: lp://staging/~loneowais/ubuntu/precise/rhythmbox/remember-the-rhythm
Merge into: lp://staging/ubuntu/precise/rhythmbox
Diff against target: 700 lines (+671/-0)
5 files modified
data/org.gnome.rhythmbox.gschema.xml (+23/-0)
plugins/remember-the-rhythm/Makefile.am (+13/-0)
plugins/remember-the-rhythm/Makefile.in (+503/-0)
plugins/remember-the-rhythm/remember-the-rhythm.plugin.in (+9/-0)
plugins/remember-the-rhythm/remember-the-rhythm.py (+123/-0)
To merge this branch: bzr merge lp://staging/~loneowais/ubuntu/precise/rhythmbox/remember-the-rhythm
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Information
Ubuntu branches Pending
Review via email: mp+82801@code.staging.launchpad.net

Description of the change

Added Remember-the-rhythm plugin.

I'm upstream for this
Upstream link: https://github.com/owais/remember-the-rhythm

To post a comment you must log in.
Revision history for this message
Owais Lone (loneowais) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Owais for your work, that seems a nice addition to rhythmbox. Did you consider trying to get it added to the rhythmbox upstream source? If not, why? Do you think it should be added to the rhythmbox package in Ubuntu or as a new source if it doesn't get added to the rhythmbox upstream source?

review: Needs Information
Revision history for this message
Owais Lone (loneowais) wrote :

Hi Sebastien,

I tried with a merge request on lp:rhythmbox but it was rejected with the reason that I should use upstream bugzilla. To be honest, I was too lazy to familiarize myself with upstream workflow and I don't really care if this lands in other distros or not. In Ubuntu, I would like it to ship with the rhythmbox or rhythmbox-plugins package.

If it can make life easier for Ubuntu maintainers, I can try to get it merged upstream. Let me know.

Thanks!

Revision history for this message
Sebastien Bacher (seb128) wrote :

Right, upstream doesn't use launchpad, the right way would be to open a bug: https://bugzilla.gnome.org/enter_bug.cgi?product=rhythmbox
Basically explaining what your code is doing with a pointer to your git

You can also try to connect to irc.gnome.org #rhythmbox and ask there if you do IRC

It would make sense to me to try to get that upstream since it would make easier to have it maintained and in sync with rhythmbox updates this way. That seems something we are interested in getting in Ubuntu in any case so keep the good work there!

Revision history for this message
Owais Lone (loneowais) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I will let upstream the time to comment and look again at your work next week

Revision history for this message
Martin Pitt (pitti) wrote :

This is now (and should) being handled in the upstream bug, so I set this as "work in progress" for now as we don't (currently) want to upload this directly to Ubuntu. If upstream rejects it, please change back to "Needs Review" so that we can re-consider how to package this. Thanks!

195. By Owais Lone

Merge in latest changes and updated remember-the-rhythm

Unmerged revisions

195. By Owais Lone

Merge in latest changes and updated remember-the-rhythm

194. By Owais Lone

Added remember-the-rhythm plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: