Merge lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-overlaygeometry-to-overlayrect-renaming into lp://staging/ubuntu-ui-toolkit/staging
Proposed by
Loïc Molinari
| Status: | Merged |
|---|---|
| Approved by: | Zsombor Egri |
| Approved revision: | 1444 |
| Merged at revision: | 1445 |
| Proposed branch: | lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-overlaygeometry-to-overlayrect-renaming |
| Merge into: | lp://staging/ubuntu-ui-toolkit/staging |
| Prerequisite: | lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-qml-code-snippets-indentation |
| Diff against target: |
204 lines (+34/-35) 6 files modified
components.api (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/ProgressBarStyle.qml (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/SliderStyle.qml (+1/-1) modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp (+11/-11) modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.h (+4/-5) tests/resources/ubuntushape/UbuntuShapeOverlayTest.qml (+16/-16) |
| To merge this branch: | bzr merge lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-overlaygeometry-to-overlayrect-renaming |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Zsombor Egri | Approve | ||
|
Review via email:
|
|||
Commit message
[UbuntuShapeOve
overlayGeometry being of type QRect, using overlayRect instead makes it more precise, less generic.
Description of the change
[UbuntuShapeOve
overlayGeometry being of type QRect, using overlayRect instead makes it more precise, less generic.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Ok, it's fine now, thanks!