Merge lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-opengles-mipmap-path-fix into lp://staging/ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Tim Peeters
Approved revision: 1682
Merged at revision: 1684
Proposed branch: lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-opengles-mipmap-path-fix
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Diff against target: 194 lines (+98/-30)
3 files modified
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+0/-1)
src/Ubuntu/Components/plugin/ucubuntushapetexture.h (+57/-3)
src/Ubuntu/Components/tools/createshapetextures.cpp (+41/-26)
To merge this branch: bzr merge lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-opengles-mipmap-path-fix
Reviewer Review Type Date Requested Status
Tim Peeters Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+274176@code.staging.launchpad.net

Commit message

Fixed OpenGL ES 2 mipmap fallback.

OpenGL ES 2 doesn't support GL_TEXTURE_MAX_LEVEL by default, it is only available via an extension. It was working on the devices where this extension is available but not on the emulator.

Description of the change

Fixed OpenGL ES 2 mipmap fallback.

OpenGL ES 2 doesn't support GL_TEXTURE_MAX_LEVEL by default, it is only available via an extension. It was working on the devices where this extension is available but not on the emulator.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Thanks. This prevents the need for setting texture max level and doesn't increase the size of the texture much.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches