Merge lp://staging/~lmi/ocb-addons/7.0-opw-596916-rgo into lp://staging/ocb-addons

Proposed by Laurent Mignon (Acsone)
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp://staging/~lmi/ocb-addons/7.0-opw-596916-rgo
Merge into: lp://staging/ocb-addons
Diff against target: 49 lines (+10/-0)
3 files modified
stock/security/stock_security.xml (+7/-0)
stock/stock.py (+1/-0)
stock/stock_view.xml (+2/-0)
To merge this branch: bzr merge lp://staging/~lmi/ocb-addons/7.0-opw-596916-rgo
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Stefan Rijnhart (Opener) code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+218476@code.staging.launchpad.net

Description of the change

Automatically derived from https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-596916-rgo for https://code.launchpad.net/~openerp/openobject-addons/7.0. Below is a copy of the original description.

Hi,

For 'stock.production.lot' object, the field 'company_id' isn't shown in it's views and there isn't any code that sets this field and there are not any record rules which provide support for multi-company environment.

This branch fixes these issues, kindly review the branch.

Thanks.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the MP.

Regards.

review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the backport! Launchpad will tell you that the branch is stacked invalidly. This should be harmless, and is fixed in the latest commits to lp-community-utils.

review: Approve (code review)
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

Stefan,

Thanks for the information. I have indeed discovered the fix after the backport.

Regards,

lmi

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10168. By Ravi Gohil (OpenERP)

[FIX] stock: no multicompany rule defined for stock.prodution.lot and the company_id field isn't shown in views hence user is not able to set the field. (Maintenance: 596916)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.