OpenERP Community Backports (Addons)

Merge lp://staging/~lmi/ocb-addons/7.0-bug1067541 into lp://staging/ocb-addons

  1. 7.0-bug1067541
  2. Merge into 7.0
Proposed by Laurent Mignon (Acsone)
Status: Merged
Merged at revision: 9406
Proposed branch: lp://staging/~lmi/ocb-addons/7.0-bug1067541
Merge into: lp://staging/ocb-addons
Diff against target: 211 lines (+155/-7)
4 files modified
account/account_invoice_view.xml (+1/-1)
hr_timesheet_invoice/hr_timesheet_invoice.py (+12/-6)
hr_timesheet_invoice/tests/__init__.py (+26/-0)
hr_timesheet_invoice/tests/test_multi_company.py (+116/-0)
To merge this branch: bzr merge lp://staging/~lmi/ocb-addons/7.0-bug1067541
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Stéphane Bidoul (Acsone) (community) code review Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+178024@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks! You may want to move your code down below the check for a valid partner_id on the analytic account in line 41, otherwise you may run into trouble if you try to access its 'lang' in l.31.

review: Needs Fixing
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

Thanks for the review!

Code modified according to your review.
(modifications also done on the branch proposed for merge on the official branch)

> Thanks! You may want to move your code down below the check for a valid
> partner_id on the analytic account in line 41, otherwise you may run into
> trouble if you try to access its 'lang' in l.31.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the changes! Looks good to me.

review: Approve
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) :
review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.