hw-health-charm

Merge charm-hw-health:str-bytes-conversion into charm-hw-health:stable/20.05

  1. Git
  2. lp:charm-hw-health
  3. str-bytes-conversion
  4. Merge into stable/20.05
Proposed by Andrea Ieri
Status: Rejected
Rejected by: Paul Goins
Proposed branch: charm-hw-health:str-bytes-conversion
Merge into: charm-hw-health:stable/20.05
Diff against target: 19 lines (+1/-2)
1 file modified
src/files/ipmi/cron_ipmi_sensors.py (+1/-2)
Reviewer Review Type Date Requested Status
Paul Goins Approve
Zachary Zehring (community) Approve
Review via email: mp+386197@code.staging.launchpad.net

Commit message

[cron_ipmi_sensors.py] decode subprocess bytes output into str

Closes-Bug: 1879603

To post a comment you must log in.
Revision history for this message
Zachary Zehring (zzehring) wrote :

Approved.

review: Approve
Revision history for this message
Paul Goins (vultaire) wrote :

LGTM, although bytes.decode('utf8') can simply be bytes.decode() as well; utf8 is the default.

review: Approve
Revision history for this message
Paul Goins (vultaire) wrote :

Actually, this was already merged into stable/20.05 previously as part of fixing lp#1882978. I unfortunately forgot to push the updates. I just pushed now; I'll mark this as resolved.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

No one subscribed via source and target branches