Created by Lubomir Rintel and last modified
Get this branch:
bzr branch lp://staging/~lkundrak/network-manager/launchpad-master

Branch merges

Related bugs

Related blueprints

Branch information

Lubomir Rintel

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at git://people.freedesktop.org/~lkundrak/lp-network-manager.

Last successful import was .

Import started on izar and finished taking 25 seconds — see the log
Import started on alnitak and finished taking 25 seconds — see the log
Import started on izar and finished taking 20 seconds — see the log
Import started on alnitak and finished taking 25 seconds — see the log

Recent revisions

12336. By Thomas Haller

auth-manager: fix potential issue iterating modified CList in _dbus_new_proxy_cb()

In the loop, we invoke callbacks. What the callbacks do, is out of control
of NMAuthManager. For example, they could cancel or schedule new
requests. Especially, cancelling invalidate the stored @safe pointer.

Fix that, by always iterate from the start of the list.

Fixes: d0563f0733ed293d67e9a0f6503e28c3f1c08f1b

12335. By Beniamino Galvani <email address hidden>

auth-manager: fix processing calls in _dbus_new_proxy_cb()

In the first loop, the element is removed only when the callback is
executed. The second loop never removes the current element. Use the
for_each macro for both.

Fixes: d0563f0733ed293d67e9a0f6503e28c3f1c08f1b

12334. By Beniamino Galvani <email address hidden>

core: fix wrong assertion when disposing NMAuthManager

The list should be empty on disposal.

Fixes: 2ea2df3184d45567fa9c44f5ef90634a779bfb75

12333. By Richard Sch├╝tz

dhcp: don't enforce broadcast flag

Requesting broadcast replies from the DHCP server can be problematic in
filtered environments like some wireless networks. Don't override the
default of using unicast. This matches the behaviour of the external DHCP


12332. By Beniamino Galvani <email address hidden>

auth-manager: don't process idle calls when the proxy creation finishes

The list of calls contains two kinds of elements: (1) calls that don't
need a D-Bus request and are only waiting for the asynchronous
invocation of the callback in an idle function; (2) calls that need a
D-Bus request and are waiting for the D-Bus proxy.

When the proxy creation finishes, only (2) calls must be canceled (if
the creation failed) or started (if the proxy was created).

Fixes: 798b2a7527bddadcec37b48183da313fbc961e45


12331. By Thomas Haller

cli/polkit: merge branch 'th/polkit-cleanup'


12329. By Beniamino Galvani <email address hidden>

cli: merge branch 'bg/nmcli-overview-rh1434527'


12328. By Thomas Haller

auth-subject: fix potential memory corruption in nm_auth_subject_to_string()

We don't want to apped the value to @buf, we want to set it.
Also, if @buf happens to be uninitialized, g_strlcat() might
determine there is nothing to append and return the buffer unmodified.
Then, the (non NULL terminated) buffer might be printed.

Note that before recent refactoring, we effectively would only call
nm_auth_subject_to_string() on auth-subjects that were of type
UNIX-PROCESS. Hence, this bug came only to light very recently,
although it was present for a long time.

Fixes: eabe7d856c243673bbaba3295ce74d72e188596d

12327. By Thomas Haller

policy: fix potential leak of subject in auto_activate_device()

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.


No subscribers.