Merge lp://staging/~liuyq0307/lava-dispatcher/problems-deploy-android into lp://staging/lava-dispatcher

1) I don't understand that part. It almost looks like its making a change that won't work with old Android builds? Does "/storage/sdcard0" need to become a config value or something?

2) +1

3) Can you explain how you make this happen. The only way I see this being possible is if your job file doesn't include a deploy action? If this is to make unit testing easier, just set target.deployment_data in your python shell or test script

4) Good catch. But why not just always set this rather than waiting for the prompt and timing out. I'd also drop the
 self.proc.sendline('echo "check rc in PS1"')
You'll see that in the job file anyway.

> 1) I don't understand that part. It almost looks like its making a change that
> won't work with old Android builds? Does "/storage/sdcard0" need to become a
> config value or something?
Good Idea
> 2) +1
>
> 3) Can you explain how you make this happen. The only way I see this being
> possible is if your job file doesn't include a deploy action? If this is to
> make unit testing easier, just set target.deployment_data in your python shell
> or test script
Usually, I use the following job to boot to the deployed android and do the following test,
this will same me the time to deploy the android:
$ cat /var/www/images/workspace/jobs/reboot.json
{
  "job_name": "reboot",
  "image_type": "android",
  "target": "panda01",
  "timeout": 18000,
  "actions": [
    {
      "command": "boot_linaro_android_image"
    }
  ]
}
$
> 4) Good catch. But why not just always set this rather than waiting for the
> prompt and timing out. I'd also drop the
> self.proc.sendline('echo "check rc in PS1"')
> You'll see that in the job file anyway.
If we don't check, we may get the PS1 like "$PS1 $PS1 [rc=$(echo \$?)]: $PS1 [rc=$(echo \$?)]:".

And about the check, we can use sendline(""), but I'd like to make it more explicitly.

Yongqin Liu <email address hidden> writes:

>> 3) Can you explain how you make this happen. The only way I see this being
>> possible is if your job file doesn't include a deploy action? If this is to
>> make unit testing easier, just set target.deployment_data in your python shell
>> or test script
> Usually, I use the following job to boot to the deployed android and do the following test,
> this will same me the time to deploy the android:
> $ cat /var/www/images/workspace/jobs/reboot.json
> {
> "job_name": "reboot",
> "image_type": "android",
> "target": "panda01",
> "timeout": 18000,
> "actions": [
> {
> "command": "boot_linaro_android_image"
> }
> ]
> }

I think we'll need to change this a bit -- maybe create actions like
"assume_android_deployed" and "assume_ubuntu_deployed" that set the
deployment_data appropriately but do not do anything else?

> $
>> 4) Good catch. But why not just always set this rather than waiting for the
>> prompt and timing out. I'd also drop the
>> self.proc.sendline('echo "check rc in PS1"')
>> You'll see that in the job file anyway.
> If we don't check, we may get the PS1 like "$PS1 $PS1 [rc=$(echo
> \$?)]: $PS1 [rc=$(echo \$?)]:".
> And about the check, we can use sendline(""), but I'd like to make it more explicitly.

I'm completely changing how prompts are handled in my prompt-sanity
branch. I hope this part of your branch is no longer needed.

Cheers,
mwh

split the sdcard mount and typo of _hard_reboot out to
https://code.launchpad.net/~liuyq0307/lava-dispatcher/sdcard-mount/+merge/129693
and
https://code.launchpad.net/~liuyq0307/lava-dispatcher/typo-hard-reboot/+merge/129694

please review there