LAVA Android Test

Merge lp://staging/~liuyq0307/lava-android-test/command-file into lp://staging/lava-android-test

command-file
Merge into trunk

Proposed by Yongqin Liu on 2012-03-16

Status:	Superseded
Proposed branch:	lp://staging/~liuyq0307/lava-android-test/command-file
Merge into:	lp://staging/lava-android-test
Diff against target:	240 lines (+91/-19) 2 files modified lava_android_test/commands.py (+54/-16) lava_android_test/testdef.py (+37/-3)
To merge this branch:	bzr merge lp://staging/~liuyq0307/lava-android-test/command-file
Related bugs:	Link a bug report
Related blueprints:	Support custom android command (Essential)

Reviewer	Review Type	Date Requested	Status
Linaro Validation Team		2012-03-16	Pending
Review via email: mp+97870@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-03-15.

This proposal has been superseded by a proposal from 2012-03-18.

Description of the change

1. Add support to push a specified android command file to android and run it on android.
2. Add some process for deal with the test result
3. Modify to use add_mutually_exclusive_group according review comment
4. Change result patterns to Parser member, so that we can change them out of the class

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2012-03-16: Posted in a previous version of this proposal

32 + if self.args.android_command and self.args.command_file:
33 + raise LavaCommandError("Please specified one option of -c and -f")
34 + if not self.args.android_command and not self.args.command_file:
35 + raise LavaCommandError("Please specified one option of -c and -f")

You should use mutex group instead:

group = parser.add_mutually_exclusive_group()
group.add_argument('-f', ...)
group.add_argument('-c', ...)

Then argparse will this check for you.

53 + STEPS_HOST_PRE = ["wget %s -O %s" % (file_url, file_name)]

I'd like us to use python on the host if possible. Downloading stuff with wget eventually means we have no error handling. This can stay as-is but we should look at the problem of how we download anything throughout lava and fix it.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2012-03-16:

+ if self.args.android_command and self.args.command_file:
39 + raise LavaCommandError("Please specified one option of -c and -f")
40 + if not self.args.android_command and not self.args.command_file:
41 + raise LavaCommandError("Please specified one option of -c and -f")

This won't be need if you indicate that both -c and -f are required

add_argument( ..., required=True)

Otherwise looks okay

lp://staging/~liuyq0307/lava-android-test/command-file updated on 2012-03-18