LAVA Core (deprected)

Merge lp://staging/~linaro-validation/lava-core/doanac-fixes into lp://staging/~zyga/lava-core/demo-3

  1. doanac-fixes
  2. Merge into demo-3
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 25
Merged at revision: 23
Proposed branch: lp://staging/~linaro-validation/lava-core/doanac-fixes
Merge into: lp://staging/~zyga/lava-core/demo-3
Diff against target: 90 lines (+22/-3)
4 files modified
history_demo.py (+1/-1)
lava/core/controllers/devices/qemu.py (+1/-1)
lava/core/utils.py (+18/-1)
setup.py (+2/-0)
To merge this branch: bzr merge lp://staging/~linaro-validation/lava-core/doanac-fixes
Reviewer Review Type Date Requested Status
Zygmunt Krynicki Approve
Review via email: mp+106932@code.staging.launchpad.net

Description of the change

Reproposing the branch against a better target so the diff makes some sense.

From the original proposal (https://code.launchpad.net/~linaro-validation/lava-core/doanac-fixes/+merge/106725):

zygmunt - not sure what you want to do with these, but here are some minro fixes I had to make to get things working for me.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

66 + def decompress(self, stream, suffix):
67 + commands = { 'gz':'gunzip', 'bz2':'bunzip2' }
68 + command = commands[suffix]
69 + uncompressed_name = stream.name[:-len(suffix)-1]
70 + self.logger.info("Uncompressing %s with %s to %s",
71 + stream.name, command, uncompressed_name)
72 + subprocess.check_call(
73 + [command, '-c', stream.name], stdout=open(uncompressed_name, 'w'))
74 + stream.name = uncompressed_name

As discussed on IRC, I'd prefer a pure python solution for reliability. I'll get this in and then rewrite it as things land to trunk. Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches