Merge ~lihow731/network-manager:ubuntu/focal into network-manager:ubuntu/focal

Proposed by Leon Liao
Status: Merged
Merged at revision: b566e7b7e0fad691e11992caf150e3265b6c9faf
Proposed branch: ~lihow731/network-manager:ubuntu/focal
Merge into: network-manager:ubuntu/focal
Diff against target: 54 lines (+32/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/add-the-NM_SETTING_WIRELESS_WAKE_ON_WLAN_IGNORE-status-check.patch (+25/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Iain Lane Pending
Review via email: mp+390544@code.staging.launchpad.net

This proposal supersedes a proposal from 2020-08-07.

Commit message

In some cases, the wow is not configured and the NM_SETTING_WIRELESS_WAKE_ON_WLAN_IGNORE is set (for to disable management of wake-on-LAN in NetworkManager).

The network manager only checks the NM_SETTING_WIRELESS_WAKE_ON_WLAN_NONE bit.
But, the NM_SETTING_WIRELESS_WAKE_ON_WLAN_IGNORE does not be check.
So, the management of wake-on-LAN still is done by NetworkManager.

Description of the change

This patch was sent to freedesktop and merged into ubuntu/master branch (in commit e7b44ef4c80907346ec7492a09c45277459924fc).
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/597

For OEM project (Focal), we need this patch. So, please help view this patch for ubuntu/focal branch.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote : Posted in a previous version of this proposal

Thanks. Can you please add some DEP-3 patch headers to the patch? Author, Description, Origin, Forwarded, Applied-Upstream at least.

Please could you expand the commit / changelog message to say what the *problem* as well as the solution is?

And it would be nice if you could submit to Debian too on Salsa, so (1) more people can benefit from the fix, and (2) it will be less delta.

Thanks again!

https://dep-team.pages.debian.net/deps/dep3/
https://salsa.debian.org/utopia-team/network-manager/

review: Needs Fixing
Revision history for this message
Leon Liao (lihow731) wrote :

@Iain,

I completed the DEP-3 patch header, please help to view it.

And, I found this patch already merged into ubuntu/master.
So, I resubmit this MP for ubuntu/focal branch.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: