Merge ~lihow731/network-manager:ubuntu/master into network-manager:ubuntu/master

Proposed by Leon Liao
Status: Superseded
Proposed branch: ~lihow731/network-manager:ubuntu/master
Merge into: network-manager:ubuntu/master
Diff against target: 54 lines (+32/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/add-the-NM_SETTING_WIRELESS_WAKE_ON_WLAN_IGNORE-status-check.patch (+25/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Iain Lane (community) Needs Fixing
Review via email:

This proposal has been superseded by a proposal from 2020-09-10.

Commit message

In some cases, the wow is not configured and the NM_SETTING_WIRELESS_WAKE_ON_WLAN_IGNORE is set (for to disable management of wake-on-LAN in NetworkManager).

The network manager only checks the NM_SETTING_WIRELESS_WAKE_ON_WLAN_NONE bit.
So, the management of wake-on-LAN still is done by NetworkManager.

Description of the change

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks. Can you please add some DEP-3 patch headers to the patch? Author, Description, Origin, Forwarded, Applied-Upstream at least.

Please could you expand the commit / changelog message to say what the *problem* as well as the solution is?

And it would be nice if you could submit to Debian too on Salsa, so (1) more people can benefit from the fix, and (2) it will be less delta.

Thanks again!

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches

to all changes: