LightDM GTK Greeter

Merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/set_session_check into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

  1. set_session_check
  2. Merge into trunk
Proposed by Andrew P.
Status: Merged
Merged at revision: 276
Proposed branch: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/set_session_check
Merge into: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 183 lines (+68/-96)
1 file modified
src/lightdm-gtk-greeter.c (+68/-96)
To merge this branch: bzr merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/set_session_check
Reviewer Review Type Date Requested Status
Sean Davis Approve
Review via email: mp+217931@code.staging.launchpad.net

Commit message

set_session(): checking for invalid value

Description of the change

set_session(): current_session must always be set to a valid value.

- checking lightdm_greeter_get_default_session_hint() result
- recursion removed
- logic stay the same: passed value -> "last-session" -> default_session_hint
- get_session(): current_value always have valid or NULL value, so unnecessary code removed

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

Looks sane to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches