Merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Andrew P.
Status: Merged
Merged at revision: 307
Proposed branch: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout
Merge into: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 3088 lines (+1319/-1051)
4 files modified
src/greeterbackground.c (+41/-82)
src/greeterbackground.h (+3/-5)
src/lightdm-gtk-greeter.c (+1091/-927)
src/lightdm-gtk-greeter.glade (+184/-37)
To merge this branch: bzr merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout
Reviewer Review Type Date Requested Status
Sean Davis Approve
Review via email: mp+233644@code.staging.launchpad.net

Description of the change

One-window layout.
Each monitor have own GtkWindow, active monitor window have GtkOverlay as a child.
GtkOverlay contains all greeter controls. GtkEventBox used as subwindow (+ "background" style class for each subwindow).

Changes:
  - GtkOverlay widget name and class - "#screen.lightdm-gtk-greeter"
  - Power dialog: http://imgur.com/2qybtO1
  - Some functions have been rearranged (+ prototypes)
  - Hiding panel if there are no indicators (fixed)
  - New option:
    panel-position = top|bottom ("top" by default)
  - New option:
    keyboard-position = x y[;width height] ("50%,center -0;50% 25%" by default)

Issues:
  - Greybird, Xubuntu 14.04 (and 14.10): http://imgur.com/MQLz3eR
    Must be: http://imgur.com/FG3FeNy
    Reason:
    /usr/share/themes/Greybird/gtk-3.0/gtk-widgets.css: "* { background-color: inherit; }"

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

I've been using this for a while now. Everything works well. I did notice that the panel is not nearly as tall as it was previously though. Can we give this a bit of padding, or make the height themable?

306. By Andrew P.

Invalid #panel_window style class

Revision history for this message
Andrew P. (kalgasnik) wrote :

There was unnecessary style class in glade file, fixed.

Revision history for this message
Sean Davis (bluesabre) wrote :

Works like a charm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches