Merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Status: | Merged |
---|---|
Merged at revision: | 307 |
Proposed branch: | lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout |
Merge into: | lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk |
Diff against target: |
3088 lines (+1319/-1051) 4 files modified
src/greeterbackground.c (+41/-82) src/greeterbackground.h (+3/-5) src/lightdm-gtk-greeter.c (+1091/-927) src/lightdm-gtk-greeter.glade (+184/-37) |
To merge this branch: | bzr merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/one-window-layout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sean Davis | Approve | ||
Review via email: mp+233644@code.staging.launchpad.net |
Description of the change
One-window layout.
Each monitor have own GtkWindow, active monitor window have GtkOverlay as a child.
GtkOverlay contains all greeter controls. GtkEventBox used as subwindow (+ "background" style class for each subwindow).
Changes:
- GtkOverlay widget name and class - "#screen.
- Power dialog: http://
- Some functions have been rearranged (+ prototypes)
- Hiding panel if there are no indicators (fixed)
- New option:
panel-position = top|bottom ("top" by default)
- New option:
keyboard-
Issues:
- Greybird, Xubuntu 14.04 (and 14.10): http://
Must be: http://
Reason:
/usr/
I've been using this for a while now. Everything works well. I did notice that the panel is not nearly as tall as it was previously though. Can we give this a bit of padding, or make the height themable?