Merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/greeter-background into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Proposed by
Andrew P.
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 295 | ||||||||||||
Proposed branch: | lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/greeter-background | ||||||||||||
Merge into: | lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk | ||||||||||||
Diff against target: |
2318 lines (+1554/-486) (has conflicts) 5 files modified
data/lightdm-gtk-greeter.conf (+3/-0) src/Makefile.am (+1/-0) src/greeterbackground.c (+1369/-0) src/greeterbackground.h (+48/-0) src/lightdm-gtk-greeter.c (+133/-486) Text conflict in src/lightdm-gtk-greeter.c |
||||||||||||
To merge this branch: | bzr merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/greeter-background | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sean Davis | Approve | ||
Review via email: mp+225019@code.staging.launchpad.net |
Description of the change
Using GreeterBackground class to manage backgrounds.
[greeter]
# Sets monitor to display greeter windows.
# Special value - "#cursor".
active-
# Default settings
background=...
user-background=...
# [monitor: name] or [monitor: number]
[monitor: VGA-0]
# Individual settings
background=...
user-background=...
[monitor: LVDS]
# Mark monitor as laptop display.
# Greeter will be moved to another monitor from the list
# (or first available) if lid is closed. false by default.
laptop=true
To post a comment you must log in.
I've tested the latest changes in the branch. While it generally seems to work fine, it all depends on whether the user has set up his monitors correctly in Xorg. E.g. my work machine defaults to cloning/mirroring the outputs, so whatever I set in the greeters conf-file, I get a rather garbled output.
I'm wondering whether we shouldn't just handle the display layout within the greeter instead of relying on Xorg's default setup.
Also: how would the user change the default Xorg layout (without xorg.conf) easily for the greeter? (You mentioned xrandr before, but that's only within a user-session so it wouldn't affect the greeter, right?)