Merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/get_session_fix into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Andrew P.
Status: Merged
Merged at revision: 274
Proposed branch: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/get_session_fix
Merge into: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 53 lines (+6/-2)
1 file modified
src/lightdm-gtk-greeter.c (+6/-2)
To merge this branch: bzr merge lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/get_session_fix
Reviewer Review Type Date Requested Status
Sean Davis Approve
Review via email: mp+217356@code.staging.launchpad.net

Description of the change

get_session() returns current_session instead of its copy. Returned value will be freed in start_session() -> current_session becomes corrupted. The same is true for get_language() and current_language.

This patch fix it.

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

This looks good. Merging now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches