Merge lp://staging/~lifeless/storm/bug-619017 into lp://staging/storm
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Gustavo Niemeyer | ||||
| Proposed branch: | lp://staging/~lifeless/storm/bug-619017 | ||||
| Merge into: | lp://staging/storm | ||||
| Diff against target: |
43 lines (+11/-6) 1 file modified
storm/store.py (+11/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~lifeless/storm/bug-619017 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Niemeyer | Disapprove | ||
| Storm Developers | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch will fix bug 619017 for launchpad : don't invoke __storm_loaded__ on unpopulated objects which we're about to insert values into (simple inspection of the code path should convince you).
I've added some editorial about the actual hook call and not affected other callers : the whole code path there looks suspect to me, but I didn't want to break something I didn't know about.
Oh, and there are no tests, as I know from the platform sprint that this is buried deep down and hard to tickle [its the second issue in this code area we've identified in the last 6 weeks or so].
It occurs to me that we could make this much simpler by discarding the object cache, but perhaps its needed for something that isn't obvious to me :)
| Thomas Herve (therve) wrote | # |
Unmerged revisions
- 371. By Robert Collins
-
Do not call __storm_loaded__ with new objects found in from _load_objects until they are actually loaded with content.
I've created another MP at https:/