Calculator

Merge lp://staging/~lexsurkov/pantheon-calculator/Bug_1465680 into lp://staging/~elementary-apps/pantheon-calculator/trunk

  1. Bug_1465680
  2. Merge into trunk
Proposed by lexsurkov
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp://staging/~lexsurkov/pantheon-calculator/Bug_1465680
Merge into: lp://staging/~elementary-apps/pantheon-calculator/trunk
Diff against target: 45 lines (+10/-2)
2 files modified
src/Core/Evaluation.vala (+9/-1)
src/Core/Scanner.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~lexsurkov/pantheon-calculator/Bug_1465680
Reviewer Review Type Date Requested Status
xapantu (community) Disapprove
Review via email: mp+270140@code.staging.launchpad.net

Commit message

Fixed Bug #1465680 Incorrectly calculating of percentages

Description of the change

Fixed Bug #1465680 Incorrectly calculating of percentages

To post a comment you must log in.
Revision history for this message
xapantu (xapantu) wrote :

Unfortunately we are discussing the bug you linked, I am not sure we reached an agreement yet =(

But I am rather sure we will not want what was described in the bug report.

review: Disapprove
Revision history for this message
lexsurkov (lexsurkov) wrote :

I am think, you must test the commit. I not destroyed work the calculator, but made corrections like making step by step calculator. I do not insist that it is the right solution, but maybe there will be new ideas.

Unmerged revisions

160. By lexsurkov

Fixed Bug #1465680 Incorrectly calculating of percentages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: