Calculator

Merge lp://staging/~lexsurkov/pantheon-calculator/Bug_1409485 into lp://staging/~elementary-apps/pantheon-calculator/trunk

Proposed by lexsurkov on 2015-09-01

Status:

Superseded

Proposed branch:

Merge into:

Diff against target:

1 file modified

src/MainWindow.vala (+6/-0)

To merge this branch:

bzr merge lp://staging/~lexsurkov/pantheon-calculator/Bug_1409485

Wishlist

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
xapantu (community)		2015-09-01	Needs Fixing on 2015-09-14
Review via email: mp+269764@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-09-01.

This proposal has been superseded by a proposal from 2015-09-15.

Fixed Bug_1409485

Fixed Bug_1409485

Revision history for this message

xapantu (xapantu) wrote on 2015-09-01: Posted in a previous version of this proposal

It looks like you forgot to commit your changes, this branch is the same as the trunk.

review: Needs Information

Revision history for this message

xapantu (xapantu) wrote on 2015-09-14:

Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?

review: Needs Fixing

Revision history for this message

lexsurkov (lexsurkov) wrote on 2015-09-15:

Thank you, hastened to, not tested in the method key_pressed. In the future, I will carefully)))
Now I corrected.
.

> 15.09.2015, 2:18:25 пользователь xapantu (<email address hidden>) написал:
>
> Review: Needs Fixing
>
> Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?
> --
> https://code.launchpad.net/~lexsurkov/pantheon-calculator/Bug_1409485/+merge/269764
> You are the owner of lp:~lexsurkov/pantheon-calculator/Bug_1409485.
>
>

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

People subscribed via source and target branches

to all changes: