Files

Merge lp://staging/~lemonboy/pantheon-files/update-free-space into lp://staging/~elementary-apps/pantheon-files/trunk

  1. update-free-space
  2. Merge into trunk
Proposed by The Lemon Man
Status: Merged
Approved by: Jeremy Wootten
Approved revision: 1967
Merged at revision: 1988
Proposed branch: lp://staging/~lemonboy/pantheon-files/update-free-space
Merge into: lp://staging/~elementary-apps/pantheon-files/trunk
Diff against target: 48 lines (+19/-12)
1 file modified
src/View/Sidebar.vala (+19/-12)
To merge this branch: bzr merge lp://staging/~lemonboy/pantheon-files/update-free-space
Reviewer Review Type Date Requested Status
Jeremy Wootten Approve
Review via email: mp+276658@code.staging.launchpad.net

Commit message

Update the size-related fields for networked filesystems.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

The indicator does not update until the Sidebar is refreshed and this does not happen unless e.g. the bookmarks are moved, renamed, deleted. However, the freespace indicator does display correctly for NFS at the time of mounting. It should be clarified whether this is sufficient to meet the requirements of the bounty; the bug report is not specific on this matter. I would say the freespace indicators should update whenever the freespace changes for any of the mounted volumes (not just NFS).

lp://staging/~lemonboy/pantheon-files/update-free-space updated
1967. By The Lemon Man

Update the sidebar on uri change.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

The free space now updates on reload (F5). This has to be done manually for local mounts if the free space changes due to pasting or deleting files since this does not trigger a reload for local devices (FileMonitor signals are used to update the view).
While it would be nice to have the freespace indicators automatically update, it can be added in another branch. I will approve this branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: