Merge lp://staging/~leeturner/quam-plures/num_blogs_config into lp://staging/quam-plures
Proposed by
Lee Turner
| Status: | Merged |
|---|---|
| Merged at revision: | 7615 |
| Proposed branch: | lp://staging/~leeturner/quam-plures/num_blogs_config |
| Merge into: | lp://staging/quam-plures |
| Diff against target: |
74 lines (+14/-4) 4 files modified
qp_inc/users/model/_usersettings.class.php (+3/-1) qp_inc/users/users.ctrl.php (+6/-0) qp_inc/users/views/_user.form.php (+3/-1) qp_view_admin/_adminUI_general.class.php (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~leeturner/quam-plures/num_blogs_config |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| EdB | Approve | ||
| Tilman Blumenbach (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
See this thread for details:
http://
Removes the hardcoded value and adds a user configurable option to specify the number of blogs to display on the blog menu in the admin console. Defaults to 10.
To post a comment you must log in.
Revision history for this message
| Lee Turner (leeturner) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Gonna make this as a comment only for the moment. The text on the User Profile page isn't very good IMHO, but I dunno what I think would be better. The thing is my first thought was "why would I limit how many - I want all of them displayed" even though I knew in my head it was referring to how many get displayed before a dropdown menu is created for all blogs beyond the number entered. I'll throw some ideas (if I have any) for the label and note out in the forums.
Otherwise works as advertised and doesn't cause problems and adds coolness so I'm totally okay with marking this "yay+" or whatever means good and doing the merge.