Merge lp://staging/~le-chi-thu/lava-android-test/add-sdcard-tests into lp://staging/lava-android-test
Proposed by
Le Chi Thu
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~le-chi-thu/lava-android-test/add-sdcard-tests |
| Merge into: | lp://staging/lava-android-test |
| Diff against target: |
345 lines (+281/-1) 8 files modified
MANIFEST.in (+2/-0) doc/changes.rst (+6/-0) doc/tests.rst (+8/-0) lava_android_test/__init__.py (+1/-1) lava_android_test/test_definitions/filetransfertest.py (+45/-0) lava_android_test/test_definitions/filetransfertest/filetransfertest.py (+140/-0) lava_android_test/test_definitions/sdcardtest.py (+36/-0) lava_android_test/test_definitions/sdcardtest/dfcheck.py (+43/-0) |
| To merge this branch: | bzr merge lp://staging/~le-chi-thu/lava-android-test/add-sdcard-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Yongqin Liu | Approve | ||
| Le Chi Thu (community) | Needs Resubmitting | ||
|
Review via email:
|
|||
Description of the change
Added SDcard and file transfer tests created by Per Andersson
To post a comment you must log in.
Revision history for this message
| Yongqin Liu (liuyq0307) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for this addition, but the bad news is that the lava deployed android image does not have the sdcard partition:(
But I'd like to integrated this first, so when we add the sdcard partition for lava deployed android image,
this test can be used immediately. Also we can use the test for data partition now.
And Here I have some comments about this.
203 +internalPath = "/sdcard/"
204 +externalPath = "/data/app/"
In android /sdcard is normally call external, so it's better to change the two variable names.
And about the "/data/app/" path, if not have special meanings I'd like to use "/data/local" instead.
311 + print "sdcard_
From the above, it seems that just used to check the mount of sdcard.
But actually we check the sdcard and data two.
And about the filetransfertest test, only one transfer is enough for the test?
Normally, only one time will not have any problem IMO.