Ubuntu
upstart package

Merge lp://staging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0 into lp://staging/ubuntu/vivid/upstart

  1. Vivid (15.04)
  2. rm-libjson0
  3. Merge into vivid
Proposed by Lance Goodridge
Status: Rejected
Rejected by: Mathieu Trudel-Lapierre
Proposed branch: lp://staging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0
Merge into: lp://staging/ubuntu/vivid/upstart
Diff against target: 44 lines (+9/-3)
2 files modified
debian/changelog (+6/-0)
debian/control (+3/-3)
To merge this branch: bzr merge lp://staging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Disapprove
Review via email: mp+247526@code.staging.launchpad.net

Commit message

Changed libjson0 to libjson-c2 in Build Dependencies

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks fine, but the Build-Depends should probably be libjson-c-dev instead.

Note; I'm looking at the upstart binary package and it looks like it probably doesn't need to Depends on libjson at all, and the upstart-bin package appears to already Depends on libjson-c2 via shlibs:Depends, so you might as well remove it from there too :)

With these changes made I think things will be just fine to merge and upload.

review: Needs Fixing
Revision history for this message
Lance Goodridge (ldgoodridge95) wrote :

Hello Mr Trudel-Lapierre,

Thank you for reviewing my patch! I have removed the two libjson0-dev
dependencies per your suggestion and have a submitted a new merge
request.

Lance

On Mon, Feb 16, 2015 at 6:01 PM, Mathieu Trudel-Lapierre
<email address hidden> wrote:
> Review: Needs Fixing
>
> Looks fine, but the Build-Depends should probably be libjson-c-dev instead.
>
> Note; I'm looking at the upstart binary package and it looks like it probably doesn't need to Depends on libjson at all, and the upstart-bin package appears to already Depends on libjson-c2 via shlibs:Depends, so you might as well remove it from there too :)
>
> With these changes made I think things will be just fine to merge and upload.
> --
> https://code.launchpad.net/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0/+merge/247526
> You are the owner of lp:~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Closing as Rejected; superseded by https://code.launchpad.net/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0-dev/+merge/250522

review: Disapprove

Unmerged revisions

1607. By Lance Goodridge

Replaced libjson0-dev with libjson-c2 in Dependencies.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches