Merge lp://staging/~lazypower/charms/trusty/kibana/add-dashboard-loader-action into lp://staging/charms/trusty/kibana

Proposed by Charles Butler
Status: Merged
Merged at revision: 22
Proposed branch: lp://staging/~lazypower/charms/trusty/kibana/add-dashboard-loader-action
Merge into: lp://staging/charms/trusty/kibana
Diff against target: 2106 lines (+1434/-3)
108 files modified
README.md (+31/-3)
actions.yaml (+7/-0)
actions/load-dashboard (+11/-0)
dashboards/beats/.gitignore (+3/-0)
dashboards/beats/LICENSE (+13/-0)
dashboards/beats/dashboards/dashboard/HTTP.json (+11/-0)
dashboards/beats/dashboards/dashboard/MongoDB-performance.json (+11/-0)
dashboards/beats/dashboards/dashboard/MySQL-performance.json (+11/-0)
dashboards/beats/dashboards/dashboard/Packetbeat-Dashboard.json (+11/-0)
dashboards/beats/dashboards/dashboard/PgSQL-performance.json (+11/-0)
dashboards/beats/dashboards/dashboard/Thrift-performance.json (+11/-0)
dashboards/beats/dashboards/dashboard/Topbeat-Dashboard.json (+15/-0)
dashboards/beats/dashboards/dashboard/Winlogbeat-Dashboard.json (+13/-0)
dashboards/beats/dashboards/index-pattern/filebeat.json (+5/-0)
dashboards/beats/dashboards/index-pattern/packetbeat.json (+5/-0)
dashboards/beats/dashboards/index-pattern/topbeat.json (+6/-0)
dashboards/beats/dashboards/index-pattern/winlogbeat.json (+5/-0)
dashboards/beats/dashboards/search/Cache-transactions.json (+20/-0)
dashboards/beats/dashboards/search/DB-transactions.json (+20/-0)
dashboards/beats/dashboards/search/Default-Search.json (+21/-0)
dashboards/beats/dashboards/search/Errors.json (+20/-0)
dashboards/beats/dashboards/search/Filesystem-stats.json (+16/-0)
dashboards/beats/dashboards/search/HTTP-errors.json (+20/-0)
dashboards/beats/dashboards/search/MongoDB-errors.json (+21/-0)
dashboards/beats/dashboards/search/MongoDB-transactions-with-write-concern-0.json (+21/-0)
dashboards/beats/dashboards/search/MongoDB-transactions.json (+21/-0)
dashboards/beats/dashboards/search/MySQL-Transactions.json (+20/-0)
dashboards/beats/dashboards/search/MySQL-errors.json (+20/-0)
dashboards/beats/dashboards/search/Packetbeat-Search.json (+16/-0)
dashboards/beats/dashboards/search/PgSQL-errors.json (+20/-0)
dashboards/beats/dashboards/search/PgSQL-transactions.json (+20/-0)
dashboards/beats/dashboards/search/Proc-stats.json (+16/-0)
dashboards/beats/dashboards/search/Processes.json (+21/-0)
dashboards/beats/dashboards/search/RPC-transactions.json (+20/-0)
dashboards/beats/dashboards/search/System-stats.json (+16/-0)
dashboards/beats/dashboards/search/System-wide.json (+22/-0)
dashboards/beats/dashboards/search/Thrift-errors.json (+20/-0)
dashboards/beats/dashboards/search/Thrift-transactions.json (+20/-0)
dashboards/beats/dashboards/search/Web-transactions.json (+20/-0)
dashboards/beats/dashboards/search/Winlogbeat-Search.json (+22/-0)
dashboards/beats/dashboards/visualization/Average-system-load-across-all-systems.json (+10/-0)
dashboards/beats/dashboards/visualization/CPU-usage-per-process.json (+10/-0)
dashboards/beats/dashboards/visualization/CPU-usage.json (+11/-0)
dashboards/beats/dashboards/visualization/Cache-transactions.json (+10/-0)
dashboards/beats/dashboards/visualization/Client-locations.json (+10/-0)
dashboards/beats/dashboards/visualization/DB-transactions.json (+10/-0)
dashboards/beats/dashboards/visualization/Disk-usage-overview.json (+10/-0)
dashboards/beats/dashboards/visualization/Disk-usage.json (+10/-0)
dashboards/beats/dashboards/visualization/Disk-utilization-over-time.json (+11/-0)
dashboards/beats/dashboards/visualization/Errors-count-over-time.json (+10/-0)
dashboards/beats/dashboards/visualization/Errors-vs-successful-transactions.json (+11/-0)
dashboards/beats/dashboards/visualization/Event-Levels.json (+10/-0)
dashboards/beats/dashboards/visualization/Evolution-of-the-CPU-times-per-process.json (+10/-0)
dashboards/beats/dashboards/visualization/HTTP-codes-for-the-top-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/HTTP-error-codes-evolution.json (+9/-0)
dashboards/beats/dashboards/visualization/HTTP-error-codes.json (+9/-0)
dashboards/beats/dashboards/visualization/Latency-histogram.json (+11/-0)
dashboards/beats/dashboards/visualization/Levels.json (+10/-0)
dashboards/beats/dashboards/visualization/Memory-usage-per-process.json (+10/-0)
dashboards/beats/dashboards/visualization/Memory-usage.json (+11/-0)
dashboards/beats/dashboards/visualization/MongoDB-commands.json (+10/-0)
dashboards/beats/dashboards/visualization/MongoDB-errors-per-collection.json (+10/-0)
dashboards/beats/dashboards/visualization/MongoDB-errors.json (+10/-0)
dashboards/beats/dashboards/visualization/MongoDB-in-slash-out-throughput.json (+10/-0)
dashboards/beats/dashboards/visualization/MongoDB-response-times-and-count.json (+10/-0)
dashboards/beats/dashboards/visualization/MongoDB-response-times-by-collection.json (+10/-0)
dashboards/beats/dashboards/visualization/Most-frequent-MySQL-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/Most-frequent-PgSQL-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/MySQL-Errors.json (+10/-0)
dashboards/beats/dashboards/visualization/MySQL-Methods.json (+10/-0)
dashboards/beats/dashboards/visualization/MySQL-Reads-vs-Writes.json (+10/-0)
dashboards/beats/dashboards/visualization/MySQL-throughput.json (+10/-0)
dashboards/beats/dashboards/visualization/Mysql-response-times-percentiles.json (+10/-0)
dashboards/beats/dashboards/visualization/Navigation.json (+10/-0)
dashboards/beats/dashboards/visualization/Number-of-Events-Over-Time-By-Event-Log.json (+10/-0)
dashboards/beats/dashboards/visualization/Number-of-Events.json (+10/-0)
dashboards/beats/dashboards/visualization/Number-of-MongoDB-transactions-with-writeConcern-w-equal-0.json (+10/-0)
dashboards/beats/dashboards/visualization/PgSQL-Errors.json (+10/-0)
dashboards/beats/dashboards/visualization/PgSQL-Methods.json (+10/-0)
dashboards/beats/dashboards/visualization/PgSQL-Reads-vs-Writes.json (+10/-0)
dashboards/beats/dashboards/visualization/PgSQL-response-times-percentiles.json (+10/-0)
dashboards/beats/dashboards/visualization/PgSQL-throughput.json (+10/-0)
dashboards/beats/dashboards/visualization/Process-status.json (+11/-0)
dashboards/beats/dashboards/visualization/RPC-transactions.json (+10/-0)
dashboards/beats/dashboards/visualization/Reads-versus-Writes.json (+10/-0)
dashboards/beats/dashboards/visualization/Response-times-percentiles.json (+11/-0)
dashboards/beats/dashboards/visualization/Response-times-repartition.json (+11/-0)
dashboards/beats/dashboards/visualization/Servers.json (+10/-0)
dashboards/beats/dashboards/visualization/Slowest-MySQL-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/Slowest-PgSQL-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/Slowest-Thrift-RPC-methods.json (+10/-0)
dashboards/beats/dashboards/visualization/Sources.json (+10/-0)
dashboards/beats/dashboards/visualization/System-load.json (+10/-0)
dashboards/beats/dashboards/visualization/Thrift-RPC-Errors.json (+10/-0)
dashboards/beats/dashboards/visualization/Thrift-requests-per-minute.json (+10/-0)
dashboards/beats/dashboards/visualization/Thrift-response-times-percentiles.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-10-HTTP-requests.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-10-memory-consumers.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-10-processes-by-total-CPU-usage.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-Event-IDs.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-Thrift-RPC-calls-with-errors.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-Thrift-RPC-methods.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-processes.json (+10/-0)
dashboards/beats/dashboards/visualization/Top-slowest-MongoDB-queries.json (+10/-0)
dashboards/beats/dashboards/visualization/Total-number-of-HTTP-transactions.json (+10/-0)
dashboards/beats/dashboards/visualization/Total-time-spent-in-each-MongoDB-collection.json (+10/-0)
dashboards/beats/dashboards/visualization/Web-transactions.json (+10/-0)
dashboards/beats/load.sh (+125/-0)
To merge this branch: bzr merge lp://staging/~lazypower/charms/trusty/kibana/add-dashboard-loader-action
Reviewer Review Type Date Requested Status
Konstantinos Tsakalozos (community) Needs Fixing
Review Queue (community) automated testing Needs Fixing
charmers Pending
Review via email: mp+289684@code.staging.launchpad.net

Description of the change

  Added an action to deploy dashboards bundled with the charm. This is useful for
  distributing dashboards created against KB4 and then making them available to
  the consumers of kibana at large.

  To use this new feature:

       juju action do kibana/0 deploy-dashboard dashboard=beats

  This deploys the beats dashboard. However this lays the framework for more
  dashboards to be loaded into the charm and leveraged in the same manner using
  Elastic co's tooling.

To post a comment you must log in.
22. By Charles Butler

And this time with the actual action files

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/3279/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/3262/

review: Needs Fixing (automated testing)
Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Hi Charles,

Thank you for your work here. I managed to test the patch and it seems to work. I can see the dashboards but I haven't tested all the available functionality, yet. I am in the process of reviewing the related charms.

An issue that needs your attention is the flakyness of 11-scale-elastic.py.
There might not be enough time for the record insertion to propagate. Also this test will succeed only the first time and fail in any subsequent runs. An idea would be to start the test by reading the results count then proceed with the insertion and finally do a continuous poll of the result with a time out. Understandably this flakyness may not be due to your patch but it is there.

Thank you for your time and effort.

review: Needs Fixing
Revision history for this message
Charles Butler (lazypower) wrote :

The test suite in this charm really needs some re-evaluation. I agree.

I'd like to address that in a different volume of work and keep this branch isolated to loading dashboards into Kibana. I've filed a bug to work on the test issues here: https://bugs.launchpad.net/charms/+source/kibana/+bug/1576706

Revision history for this message
Matt Bruzek (mbruzek) wrote :

The action name is not correct in the README. Also in juju2 action is not a subcommand.

juju run-action kibana/0 load-dashboard dashboard=beats

Revision history for this message
Matt Bruzek (mbruzek) wrote :

There was some additional things I needed to do in the kibana GUI to view the dashboards. If you are already updating the README please include those steps, such as setting a default index and loading the dashboards.

23. By Charles Butler

Updates README with proper action name (Sorry about that)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches