Juju Charms Collection
elasticsearch package

Merge lp://staging/~lazypower/charms/trusty/elasticsearch/play-it-again-sam into lp://staging/charms/trusty/elasticsearch

  1. Trusty Tahr (14.04)
  2. play-it-again-sam
  3. Merge into trunk
Proposed by Charles Butler
Status: Merged
Approved by: Charles Butler
Approved revision: 44
Merged at revision: 43
Proposed branch: lp://staging/~lazypower/charms/trusty/elasticsearch/play-it-again-sam
Merge into: lp://staging/charms/trusty/elasticsearch
Diff against target: 302 lines (+119/-140)
7 files modified
hooks/hooks.py (+5/-4)
tests/00-create-index (+0/-32)
tests/00-single-to-scale-test.py (+112/-0)
tests/01-config-changes (+0/-22)
tests/02-deploy-three-units (+0/-18)
tests/helpers/__init__.py (+0/-64)
tests/tests.yaml (+2/-0)
To merge this branch: bzr merge lp://staging/~lazypower/charms/trusty/elasticsearch/play-it-again-sam
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Review via email: mp+293799@code.staging.launchpad.net

Description of the change

Lint fixes
Refactored the amulet test suite according to current best practices

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

Looks good, thanks for resubmitting! +1

review: Approve
lp://staging/~lazypower/charms/trusty/elasticsearch/play-it-again-sam updated
44. By Charles Butler

Fixed flake8 e901 - Invalid Syntax on os.chmod() call.

Revision history for this message
Charles Butler (lazypower) wrote :

this made it in as of cs:trusty/elasticsearch-15

@tribaal - do we need to get this merged in that lp branch?

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Done :)

Also, let me know if you think it makes sense to move this back to a branch you control. We took ownership at the time because we were the only ones using it in prod and needed to land without blocking on the long reviews. I'm happy to leave it as is, but given that it no longer requires lots of updates from us (it's working well now), it's fine if you want to move it back.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches