Merge lp://staging/~lazypower/charms/precise/phpmyadmin/audit-fixes into lp://staging/charms/phpmyadmin

Proposed by Charles Butler
Status: Work in progress
Proposed branch: lp://staging/~lazypower/charms/precise/phpmyadmin/audit-fixes
Merge into: lp://staging/charms/phpmyadmin
Diff against target: 152 lines (+120/-1)
5 files modified
.bzrignore (+4/-0)
hooks/start (+1/-0)
metadata.yaml (+2/-1)
tests/00-setup (+5/-0)
tests/100-deploy (+108/-0)
To merge this branch: bzr merge lp://staging/~lazypower/charms/precise/phpmyadmin/audit-fixes
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+208151@code.staging.launchpad.net

Description of the change

Audit fixes & Tests

Updated metadata with proper interface listing
added amulet tests for deployment
added bzrignore
added vagrant testing files to bzrignore

https://codereview.appspot.com/68590043/

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

Reviewers: mp+208151_code.launchpad.net,

Message:
Please take a look.

Description:
Audit fixes & Tests

Updated metadata with proper interface listing
added amulet tests for deployment
added bzrignore
added vagrant testing files to bzrignore

https://code.launchpad.net/~lazypower/charms/precise/phpmyadmin/audit-fixes/+merge/208151

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/68590043/

Affected files (+122, -1 lines):
   A .bzrignore
   A [revision details]
   M hooks/start
   M metadata.yaml
   A tests/00-setup
   A tests/100-deploy

Unmerged revisions

46. By Charles Butler

Updated bzrignore for proper vagrant test runner shellscript

45. By Charles Butler

Updates to amulet tests

44. By Charles Butler

Checkpoint commit for functional tests without config file validation

43. By Charles Butler

Dont track the vagrant files, or test output

42. By Charles Butler

Corrects metadata missing interface, adds restart process to apache2 on start hook

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: