Merge lp://staging/~laurynas-biveinis/percona-xtrabackup/bug1022562-2.0 into lp://staging/percona-xtrabackup/2.0

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 453
Proposed branch: lp://staging/~laurynas-biveinis/percona-xtrabackup/bug1022562-2.0
Merge into: lp://staging/percona-xtrabackup/2.0
Prerequisite: lp://staging/~sergei.glushchenko/percona-xtrabackup/xb20-bug932623
Diff against target: 145 lines (+111/-4)
2 files modified
src/xtrabackup.c (+18/-4)
test/t/bug1022562.sh (+93/-0)
To merge this branch: bzr merge lp://staging/~laurynas-biveinis/percona-xtrabackup/bug1022562-2.0
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Review via email: mp+116624@code.staging.launchpad.net

Description of the change

Fix bug 1022562 (Inc backup fails if a tablespace is created between
full and inc backups).

The issue is that with the testcase workload, the 1st 4
(FIL_IBD_FILE_INITIAL_SIZE) pages of a new tablespace were not flushed
from the buffer pool between the full and incremental backups, thus
they were not a part of the delta and on backup prepare a new
tablespace was created from scratch. But that tablespace did not have
its 1st page flags initialized properly, resulting in InnoDB errors.

Fixed by always storing the 1st FIL_IBD_FILE_INITIAL_SIZE pages in the
incremental backup delta. Also added a comment to
xb_delta_open_matching_space() that this function does not create a
"regular" tablespace but only its file. Added a testcase for this
bug.

Jenkins: http://jenkins.percona.com/job/percona-xtrabackup-2.0-param/228/

I used lp:~sergei.glushchenko/percona-xtrabackup/xb20-bug932623 as a prerequisite branch as it refactored out the tablespace load/open code and is already approved for merge.

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Issue #16274

Revision history for this message
Stewart Smith (stewart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches