Unity Control Center

Merge lp://staging/~larsu/unity-control-center/add-overlay-scrollbar-key into lp://staging/unity-control-center

  1. add-overlay-scrollbar-key
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~larsu/unity-control-center/add-overlay-scrollbar-key
Merge into: lp://staging/unity-control-center
Diff against target: 71 lines (+11/-12)
1 file modified
panels/appearance/cc-appearance-panel.c (+11/-12)
To merge this branch: bzr merge lp://staging/~larsu/unity-control-center/add-overlay-scrollbar-key
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Disapprove
Robert Ancell Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+227758@code.staging.launchpad.net

Commit message

appearance: introduce X-Ubuntu-UseOverlayScrollbars

So that theme authors can opt in to using overlay scrollbars.

Description of the change

appearance: introduce X-Ubuntu-UseOverlayScrollbars

So that theme authors can opt in to using overlay scrollbars.

This should land at the same time as lp:~larsu/ubuntu-themes/use-overlay-scrollbars. Otherwise, overlay-scrollbars will be turned off for Ambiance and Radiance as well.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:12786
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/104/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-armhf-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/104/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looks good, but why did you remove the g_settings_delay / g_settings_apply?

review: Needs Information
Revision history for this message
Lars Karlitski (larsu) wrote :

> Looks good, but why did you remove the g_settings_delay / g_settings_apply?

Because canonical_interface_settings has only ever one key set (the overlay-scrollbar one). delay/apply only makes sense when you set multiple keys at once (to only trigger one write of the dconf db) or when you have a dialog that is not instant-apply.

Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve
Revision history for this message
Lars Karlitski (larsu) wrote :

This is actually not the right place for deciding whether to show overlay-scrollbars. Instead, the overlay scrollbar module should look at the key and only enable itself when the theme supports this. The gsettings key can then be used as a manual override for users.

I've done this at https://code.launchpad.net/~larsu/overlay-scrollbar/only-enable-for-supported-themes

Thanks to Ryan for bringing this to my attention.

review: Disapprove

Unmerged revisions

12786. By Lars Karlitski

appearance: introduce X-Ubuntu-UseOverlayScrollbars

So that theme authors can opt in to using overlay scrollbars.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches