Merge lp://staging/~larsu/unico/remove-focus-attributes into lp://staging/unico

Proposed by Lars Karlitski
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 151
Merged at revision: 151
Proposed branch: lp://staging/~larsu/unico/remove-focus-attributes
Merge into: lp://staging/unico
Diff against target: 54 lines (+9/-21)
2 files modified
unico/unico-draw.c (+9/-3)
unico/unico-engine.c (+0/-18)
To merge this branch: bzr merge lp://staging/~larsu/unico/remove-focus-attributes
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+200813@code.staging.launchpad.net

Commit message

Use outline attributes for focus to avoid custom attributes

Custom attributes are deprecated, slow, and are causing problems with gtk 3.10. Adwaita is using the same hack for some time now [1]. This patch is a bit more hacky in that it hard codes the a fill color.

[1] https://git.gnome.org/browse/gnome-themes-standard/commit/?id=6e641cf46cc70ce770482b3fc331b1fa3cd7af2b

Description of the change

Use outline attributes for focus to avoid custom attributes

Custom attributes are deprecated, slow, and are causing problems with gtk 3.10. Adwaita is using the same hack for some time now [1]. This patch is a bit more hacky in that it hard codes the a fill color.

[1] https://git.gnome.org/browse/gnome-themes-standard/commit/?id=6e641cf46cc70ce770482b3fc331b1fa3cd7af2b

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

Add a comment on the 0.2...

Revision history for this message
Andrea Cimitan (cimi) wrote :

actually just saw you added it on top :)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches