Telepathy Indicator

Merge lp://staging/~larsu/telepathy-indicator/lp1302930 into lp://staging/telepathy-indicator

  1. lp1302930
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Charles Kerr
Approved revision: 80
Merged at revision: 79
Proposed branch: lp://staging/~larsu/telepathy-indicator/lp1302930
Merge into: lp://staging/telepathy-indicator
Diff against target: 146 lines (+61/-15)
1 file modified
src/indicator-approver.c (+61/-15)
To merge this branch: bzr merge lp://staging/~larsu/telepathy-indicator/lp1302930
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+215855@code.staging.launchpad.net

Commit message

Remove source when a connection dies

Description of the change

Remove source when a connection dies

Keep a hashtable mapping connections to all sources that are associated with that connection. When the connection dies, remove those sources.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/telepathy-indicator-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-indicator-ci/3/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Seems like we should be able to call update_launcher() once after removing all the items. Not critical, but seems like it would be better.

Top approve if you want to land as-is.

review: Approve
lp://staging/~larsu/telepathy-indicator/lp1302930 updated
80. By Lars Karlitski

Don't unnecessarily call update_launcher()

Revision history for this message
Lars Karlitski (larsu) wrote :

Good catch, thanks. Fixed in r80.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:80
http://jenkins.qa.ubuntu.com/job/telepathy-indicator-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-indicator-trusty-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-indicator-ci/4/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Housekeeping: top-approving based on ted's approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: