Merge lp://staging/~larsu/qmenumodel/use-full-action-name into lp://staging/~phablet-team/qmenumodel/trunk

Proposed by Lars Karlitski
Status: Merged
Approved by: Nick Dedekind
Approved revision: 91
Merged at revision: 87
Proposed branch: lp://staging/~larsu/qmenumodel/use-full-action-name
Merge into: lp://staging/~phablet-team/qmenumodel/trunk
Diff against target: 322 lines (+120/-34)
6 files modified
libqmenumodel/src/gtk/gtkmenutrackeritem.c (+21/-8)
libqmenumodel/src/gtk/gtkmenutrackeritem.h (+3/-1)
libqmenumodel/src/unitymenuaction.cpp (+15/-1)
libqmenumodel/src/unitymenuaction.h (+7/-0)
libqmenumodel/src/unitymenumodel.cpp (+73/-24)
libqmenumodel/src/unitymenumodel.h (+1/-0)
To merge this branch: bzr merge lp://staging/~larsu/qmenumodel/use-full-action-name
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+183453@code.staging.launchpad.net

Commit message

Use fully namespaced action name in UnityMenuModel::activate and for the action role

Description of the change

Use fully namespaced action name in UnityMenuModel::activate and for the action role

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
89. By Lars Karlitski

Add UnityMenuModel::getAction

A method that returns a UnityMenuAction for a menu item. It must be used if the
action name came from an attribute on the menu item so that the menu item's
namespace can be prepended to the action name.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
90. By Lars Karlitski

Add UnityMenuAction::index property

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
91. By Lars Karlitski

fullActioName: make sure 'name' is valid for the duration of the function

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

LGTM.
Works as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches