overlay-scrollbar

Merge lp://staging/~larsu/overlay-scrollbar/only-enable-for-supported-themes into lp://staging/overlay-scrollbar

  1. only-enable-for-supported-themes
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Needs review
Proposed branch: lp://staging/~larsu/overlay-scrollbar/only-enable-for-supported-themes
Merge into: lp://staging/overlay-scrollbar
Diff against target: 116 lines (+55/-11)
1 file modified
os/os-scrollbar.c (+55/-11)
To merge this branch: bzr merge lp://staging/~larsu/overlay-scrollbar/only-enable-for-supported-themes
Reviewer Review Type Date Requested Status
Iain Lane (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Ayatana Scrollbar Team Pending
Review via email: mp+228666@code.staging.launchpad.net

Commit message

Only show scrollbars if the theme supports it

Keep the gsetting so that users can override this.

Description of the change

Only show scrollbars if the theme supports it

Keep the gsetting so that users can override this. This way we never accidentally enable overlay scrollbars in themes that don't support it.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:386
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-utopic-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-utopic-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-utopic-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/overlay-scrollbar-ci/17/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Iain Lane (laney) wrote :

Just found this while proposing another MP. I guess it's still necessary so here is a small review. :)

review: Needs Fixing
Reply

Unmerged revisions

386. By Lars Karlitski

Only show scrollbars if the theme supports it

Keep the gsetting so that users can override this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches