overlay-scrollbar

Merge lp://staging/~larsu/overlay-scrollbar/hide-scrollbars-before-unmapping into lp://staging/overlay-scrollbar

  1. hide-scrollbars-before-unmapping
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 384
Merged at revision: 383
Proposed branch: lp://staging/~larsu/overlay-scrollbar/hide-scrollbars-before-unmapping
Merge into: lp://staging/overlay-scrollbar
Diff against target: 23 lines (+5/-2)
1 file modified
os/os-scrollbar.c (+5/-2)
To merge this branch: bzr merge lp://staging/~larsu/overlay-scrollbar/hide-scrollbars-before-unmapping
Reviewer Review Type Date Requested Status
Andrea Cimitan Approve
PS Jenkins bot (community) continuous-integration Approve
Sebastien Bacher (community) Approve
Review via email: mp+197415@code.staging.launchpad.net

Commit message

Hide scrollbars before unmapping them

Otherwise gtk_widget_pop_verify_invariants throws a warning about unrealizing a visible widget.

Description of the change

Hide scrollbars before unmapping them

Otherwise gtk_widget_pop_verify_invariants throws a warning about unrealizing a visible widget.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:383
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/overlay-scrollbar-ci/12/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

great, no warning since the update and no visible side effect

review: Approve
lp://staging/~larsu/overlay-scrollbar/hide-scrollbars-before-unmapping updated
384. By Lars Karlitski

Remove redundant call to gtk_widget_map()

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:384
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-trusty-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/overlay-scrollbar-ci/13/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches