lp://staging/~larsu/indicator-messages/show-separators

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/indicator-messages/12.10

Charles Kerr (community): Approve on 2012-09-14

jenkins (community): Needs Fixing (continuous-integration) on 2012-09-14

Diff: 102 lines (+12/-21)

3 files modified

configure.ac (+1/-1)
src/indicator-messages.c (+9/-19)
src/messages-service.c (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1048245: No separators in Messaging Menu

High

Fix Released

Link a bug report

Related blueprints

314. By Lars Karlitski on 2012-09-14

messages-services: don't call g_object_unref with NULL

313. By Lars Karlitski on 2012-09-13

Show menu separators between sections

Previously, gtk didn't support changing the menu model on an already-created
GtkMenu. Since IndicatorObject doesn't allow changing the GtkMenu it exports
to the panel, IndicatorMessages created a menu with a single section, into
which the menu from the service was inserted (and removed when the service
died). This led to seperators not being shown, because separators are only
shown between top-level sections.

Gtk now has gtk_menu_shell_bind_model, which allows us to get rid of top-level
wrapper section.

312. By Lars Karlitski on 2012-09-06

messages-service: update chat section when an app is removed

311. By Lars Karlitski on 2012-09-06

messages-service: fix merge error

Check whether no apps are left in remove_section instead of remove_application,
so that it is also done when an AppSection emits "destroy". This is a result
of improper merging of the watch-desktop-files and hide-indicator branches.

310. By Lars Karlitski on 2012-09-06

Merge lp:~larsu/indicator-messages/watch-desktop-files

309. By Lars Karlitski on 2012-09-05

Hide the indicator when no application is configured to use it.. Fixes: https://bugs.launchpad.net/bugs/661059, https://bugs.launchpad.net/bugs/1045039. Approved by jenkins, Charles Kerr.

308. By Lars Karlitski on 2012-09-04

Some minor enhancements to the in-source documentation.. Approved by jenkins, Charles Kerr.

307. By Lars Karlitski on 2012-09-04

Draw counts as lozenges again.

Introduces IdoDetailLabel, a GtkWidget that renders detail strings (e.g. as lozenges) on the right side of a menu item.. Approved by Charles Kerr.

306. By Lars Karlitski on 2012-09-03

Update bzrignore

305. By Lars Karlitski on 2012-09-01

libmessaging-menu: make generated .gir compatible with vala

In particular, mamke sure the <c:namespace> and <package> tags are included in
the .gir.

Fixes launchpad bug #1044096, thanks Jim!