Messaging Menu

Merge lp://staging/~larsu/indicator-messages/lp956147 into lp://staging/indicator-messages/0.3

  1. lp956147
  2. Merge into trunk.0.6
Proposed by Lars Karlitski
Status: Merged
Approved by: Charles Kerr
Approved revision: 266
Merged at revision: 269
Proposed branch: lp://staging/~larsu/indicator-messages/lp956147
Merge into: lp://staging/indicator-messages/0.3
Diff against target: 22 lines (+1/-4)
1 file modified
src/messages-service.c (+1/-4)
To merge this branch: bzr merge lp://staging/~larsu/indicator-messages/lp956147
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+101407@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Looks good!

I noticed that dbusmenu-glib's menuitem.h has this:

> #define DBUSMENU_MENUITEM_ICON_NAME_BLANK "blank-icon"

so I tweaked the patch to use the symbolic name rather than the string literal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches