Merge lp://staging/~larsu/indicator-datetime/dont-use-gdbusproxy into lp://staging/indicator-datetime/15.10
Status: | Rejected |
---|---|
Rejected by: | Charles Kerr |
Proposed branch: | lp://staging/~larsu/indicator-datetime/dont-use-gdbusproxy |
Merge into: | lp://staging/indicator-datetime/15.10 |
Prerequisite: | lp://staging/~laney/indicator-datetime/timedated-timezone-property |
Diff against target: |
184 lines (+35/-107) 1 file modified
src/timezone-timedated.cpp (+35/-107) |
To merge this branch: | bzr merge lp://staging/~larsu/indicator-datetime/dont-use-gdbusproxy |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Needs Resubmitting | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+270081@code.staging.launchpad.net |
Commit message
Use timedated's Timezone property to find out the current timezone and learn about changes to it
Description of the change
Use timedated's Timezone property to find out the current timezone and learn about changes to it
Unmerged revisions
- 426. By Lars Karlitski
-
timezone-timedated: subscribe to PropertiesChanged directly
This avoids some unnecessary calls that GDBusProxy makes and the name
watching. - 425. By Iain Lane
-
Make test-live-actions quit itself once the tz has been changed, the mock no longer does this
- 424. By Iain Lane
-
Avoid nested GMainLoops by reading from the file on startup
Restore some tests for this functionality.
- 423. By Iain Lane
-
Add some comments
- 422. By Iain Lane
-
Rename FileTimezone to TimedatedTimezone
- 421. By Iain Lane
-
Add a timeout so we can't hang forever
- 420. By Iain Lane
-
Use timedated's Timezone property instead of watching /etc/timezone
Still need to rename everything to not use "timezone-file"
PASSED: Continuous integration, rev:426 jenkins. qa.ubuntu. com/job/ indicator- datetime- ci/331/ jenkins. qa.ubuntu. com/job/ indicator- datetime- wily-amd64- ci/21 jenkins. qa.ubuntu. com/job/ indicator- datetime- wily-armhf- ci/21 jenkins. qa.ubuntu. com/job/ indicator- datetime- wily-armhf- ci/21/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- datetime- ci/331/ rebuild
http://