Merge lp://staging/~larsu/indicator-appmenu/lp1042824 into lp://staging/indicator-appmenu/12.10

Proposed by Lars Karlitski
Status: Merged
Approved by: Lars Karlitski
Approved revision: 220
Merge reported by: Lars Karlitski
Merged at revision: not available
Proposed branch: lp://staging/~larsu/indicator-appmenu/lp1042824
Merge into: lp://staging/indicator-appmenu/12.10
Diff against target: 585 lines (+290/-103)
3 files modified
src/hudindicatorsource.c (+32/-10)
src/hudmenumodelcollector.c (+251/-93)
src/hudmenumodelcollector.h (+7/-0)
To merge this branch: bzr merge lp://staging/~larsu/indicator-appmenu/lp1042824
Reviewer Review Type Date Requested Status
desrt (community) Approve
Review via email: mp+126448@code.staging.launchpad.net
To post a comment you must log in.
212. By Lars Karlitski

hudmenumodelcollector: only install a single qdata models

213. By Lars Karlitski

hudmenumodelcollector: introduce explicit application mode

Previously, indicator actions prefixed with "win." would be ignored.

214. By Lars Karlitski

hudmenumodelcollector: get rid of conditional free

215. By Lars Karlitski

hudmenumodelcollector: move context and namespace logic into hud_item_context_new

216. By desrt

Clean up HudMenuModelCollector a bit

Mostly, add some functionality to HudMenuModelContext (formerly
HudItemContext) and HudModelItem in order to reduce the growing
complexity of hud_menu_model_context_model_changed().

Add some comments.

217. By desrt

HudMenuModelCollector: store the prefix in the instance

When the menu is refreshed (which can happen any time an item is
removed) the menus are rebuilt and we need to know the prefix in order
to handle that.

218. By desrt

HudMenuModelCollector: untangle code a bit (no functional changes)

Move some functions around so that all of HudMenuModelContext is grouped
together, at the top.

219. By Lars Karlitski

hudmenumodelcollector: call add_model after the collector is initialized

220. By Lars Karlitski

hudmenumodelcollector: don't show underscores in the hud

Revision history for this message
desrt (desrt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches