Merge lp://staging/~larsu/ido/lp1231796 into lp://staging/ido/14.04
Proposed by
Lars Karlitski
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 173 |
| Merged at revision: | 174 |
| Proposed branch: | lp://staging/~larsu/ido/lp1231796 |
| Merge into: | lp://staging/ido/14.04 |
| Diff against target: |
61 lines (+18/-11) 1 file modified
src/idoplaybackmenuitem.c (+18/-11) |
| To merge this branch: | bzr merge lp://staging/~larsu/ido/lp1231796 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Charles Kerr (community) | Approve | ||
|
Review via email:
|
|||
Commit message
idoplaybackmenu
The active flag is used to signal the theme that the spinner should animate. Using that flag is a bit weird, but it's consistent with GtkSpinner and thus doesn't require special handling in the theme.
Description of the change
idoplaybackmenu
The active flag is used to signal the theme that the spinner should animate. Using that flag is a bit weird, but it's consistent with GtkSpinner and thus doesn't require special handling in the theme.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM.
Even without the bugfix this is a nice minor cleanup, since we always want to queue a redraw after changing the state, it's clean to extract that into its own method like this...