Indicator Display Objects

Merge lp://staging/~larsu/ido/lp1080076 into lp://staging/ido/14.04

lp1080076
Merge into trunk.14.04

Proposed by Lars Karlitski on 2014-04-23

Status:

Merged

Approved by:

Charles Kerr on 2014-04-23

Approved revision:

186

Merged at revision:

183

Proposed branch:

lp://staging/~larsu/ido/lp1080076

Merge into:

lp://staging/ido/14.04

Diff against target:

405 lines (+119/-88)

2 files modified

src/idomediaplayermenuitem.c (+39/-24)
src/idoplaybackmenuitem.c (+80/-64)

To merge this branch:

bzr merge lp://staging/~larsu/ido/lp1080076

Wishlist

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2014-04-23	Approve on 2014-04-23
PS Jenkins bot (community)	continuous-integration		Approve on 2014-04-23
Review via email: mp+216864@code.staging.launchpad.net

Commit message

Make long track infos better readable

By (a) making the width of the menu slightly larger and (b) reducing the font size.

Also removes the hard-coded width of 200px in favor of a width based on font size (25 characters) and center the playback widget horizontally.

Description of the change

Make long track infos better readable

By (a) making the width of the menu slightly larger and (b) reducing the font size.

Also removes the hard-coded width of 200px in favor of a width based on font size (25 characters) and center the playback widget horizontally.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-23:

PASSED: Continuous integration, rev:185
http://jenkins.qa.ubuntu.com/job/ido-ci/65/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/ido-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ido-ci/65/rebuild

review: Approve (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2014-04-23:

A good improvement.

One thing I'd like to see is for the new numbers 41, 2, and 76 introduced
in ido_playback_menu_item_draw() to be #defined instead of being raw magic
numbers.

I realize idomediaplayermenuitem.c is already a mess and don't have
any illusions about this making the code right. Still, the signposting will
be useful to anyone who has to work this code in the future.

review: Needs Fixing

lp://staging/~larsu/ido/lp1080076 updated on 2014-04-23